chaoqin-li1123 commented on code in PR #46651:
URL: https://github.com/apache/spark/pull/46651#discussion_r1607079327
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/python/PythonStreamingSinkCommitRunner.scala:
##########
@@ -39,78 +35,22 @@ import org.apache.spark.sql.types.StructType
* from the socket, then commit or abort a microbatch.
*/
class PythonStreamingSinkCommitRunner(
Review Comment:
It is similar except that streaming commit runner also takes the batch id as
parameter and throw a different type of exception.
##########
python/pyspark/sql/streaming/python_streaming_source_runner.py:
##########
@@ -210,7 +210,8 @@ def main(infile: IO, outfile: IO) -> None:
# Read information about how to connect back to the JVM from the
environment.
java_port = int(os.environ["PYTHON_WORKER_FACTORY_PORT"])
auth_secret = os.environ["PYTHON_WORKER_FACTORY_SECRET"]
- (sock_file, _) = local_connect_and_auth(java_port, auth_secret)
+ (sock_file, sock) = local_connect_and_auth(java_port, auth_secret)
+ sock.settimeout(None)
Review Comment:
comment added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
