ianmcook commented on code in PR #46529: URL: https://github.com/apache/spark/pull/46529#discussion_r1608158396
########## python/pyspark/sql/context.py: ########## @@ -46,6 +46,7 @@ if TYPE_CHECKING: from py4j.java_gateway import JavaObject + import pyarrow as pa Review Comment: I think it is OK inside when `TYPE_CHECKING` is True. There is another file in the repo that has had `import pyarrow as pa` inside an `if TYPE_CHECKING:` conditional since 2021: https://github.com/apache/spark/pull/34101/files#diff-a4f1631a18d1b4921b8727e1d78059a1014c433239eb107962c473c6466214e5R29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org