PetarVasiljevic-DB commented on code in PR #45537:
URL: https://github.com/apache/spark/pull/45537#discussion_r1609798248
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/DB2IntegrationSuite.scala:
##########
@@ -45,15 +45,18 @@ class DB2IntegrationSuite extends
DockerJDBCIntegrationV2Suite with V2JDBCTest {
"scan with aggregate push-down: REGR_INTERCEPT with DISTINCT",
"scan with aggregate push-down: REGR_SLOPE with DISTINCT",
"scan with aggregate push-down: REGR_R2 with DISTINCT",
- "scan with aggregate push-down: REGR_SXY with DISTINCT")
+ "scan with aggregate push-down: REGR_SXY with DISTINCT",
+ "simple timestamps roundtrip",
+ "simple timestamps pushdown")
override val catalogName: String = "db2"
override val namespaceOpt: Option[String] = Some("DB2INST1")
override val db = new DB2DatabaseOnDocker
+ override def url: String = db.getJdbcUrl(dockerIp, externalPort)
Review Comment:
Can't really because `db.getJdbcUrl(dockerIp, externalPort)` is dependent on
`DockerJDBCIntegrationV2Suite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
