Ngone51 commented on code in PR #46641:
URL: https://github.com/apache/spark/pull/46641#discussion_r1611187248
##########
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala:
##########
@@ -206,11 +206,11 @@ private[deploy] class ExecutorRunner(
case interrupted: InterruptedException =>
logInfo("Runner thread for executor " + fullId + " interrupted")
state = ExecutorState.KILLED
- killProcess(None)
+ killProcess(s"Runner thread for executor $fullId interrupted")
case e: Exception =>
logError("Error running executor", e)
state = ExecutorState.FAILED
- killProcess(Some(e.toString))
+ killProcess(s"Error running executor: $e")
Review Comment:
> logError("Error running executor", e)
This ^ should already log the full stack in the worker log.
My concern is that the exception that throw here could be rare case and full
stack will help the debug. Since worker already logs it, I'm fine to return a
short error message to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
