yaooqinn commented on code in PR #46440: URL: https://github.com/apache/spark/pull/46440#discussion_r1616629781
########## connector/connect/common/src/test/resources/query-tests/explain-results/function_shiftleft.explain: ########## @@ -1,2 +1,2 @@ -Project [shiftleft(cast(b#0 as int), 2) AS shiftleft(b, 2)#0] +Project [(cast(b#0 as int) << 2) AS (b << 2)#0] Review Comment: One more question here, shall we revert or keep changes in auto-generated shift expressions? Plans that are represented with symbols appear to have better readability than lowercased function names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org