GideonPotok commented on code in PR #46597:
URL: https://github.com/apache/spark/pull/46597#discussion_r1620663435
##########
sql/core/benchmarks/CollationBenchmark-results.txt:
##########
@@ -1,54 +1,79 @@
-OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1018-azure
+OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1021-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - equalsFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
--------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 3571 3576
7 0.0 35708.8 1.0X
-UNICODE 2235 2240
7 0.0 22349.2 1.6X
-UTF8_BINARY 2237 2242
6 0.0 22371.7 1.6X
-UNICODE_CI 18733 18817
118 0.0 187333.8 0.2X
+UTF8_BINARY_LCASE 3268 3279
16 0.0 32676.7 1.0X
+UNICODE 2086 2087
2 0.0 20857.9 1.6X
+UTF8_BINARY 2085 2088
4 0.0 20854.2 1.6X
+UNICODE_CI 19807 19813
7 0.0 198074.9 0.2X
-OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1018-azure
+OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1021-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - compareFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 4260 4290
41 0.0 42602.6 1.0X
-UNICODE 19536 19624
124 0.0 195360.2 0.2X
-UTF8_BINARY 3582 3612
43 0.0 35818.5 1.2X
-UNICODE_CI 20381 20454
103 0.0 203814.1 0.2X
+UTF8_BINARY_LCASE 3839 3843
6 0.0 38389.8 1.0X
+UNICODE 19096 19136
57 0.0 190955.4 0.2X
+UTF8_BINARY 3196 3197
2 0.0 31955.7 1.2X
+UNICODE_CI 19038 19043
7 0.0 190383.4 0.2X
-OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1018-azure
+OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1021-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - hashFunction: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 7347 7349
3 0.0 73467.1 1.0X
-UNICODE 73462 73608
206 0.0 734623.2 0.1X
-UTF8_BINARY 5775 5815
57 0.0 57746.0 1.3X
-UNICODE_CI 57543 57619
108 0.0 575425.2 0.1X
+UTF8_BINARY_LCASE 6914 6921
10 0.0 69135.3 1.0X
+UNICODE 67702 67724
31 0.0 677019.3 0.1X
+UTF8_BINARY 5330 5341
15 0.0 53296.6 1.3X
+UNICODE_CI 65340 65342
3 0.0 653395.9 0.1X
-OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1018-azure
+OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1021-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - contains: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 15415 15424
13 0.0 154147.1 1.0X
-UNICODE 8091 8108
25 0.0 80907.9 1.9X
-UTF8_BINARY 8964 8979
21 0.0 89643.5 1.7X
-UNICODE_CI 469123 474822
8060 0.0 4691227.7 0.0X
+UTF8_BINARY_LCASE 116495 116514
26 0.0 1164948.6 1.0X
+UNICODE 52216 52232
22 0.0 522164.7 2.2X
+UTF8_BINARY 8520 8522
3 0.0 85196.9 13.7X
+UNICODE_CI 428772 429164
553 0.0 4287724.0 0.3X
-OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1018-azure
+OpenJDK 64-Bit Server VM 17.0.11+9-LTS on Linux 6.5.0-1021-azure
AMD EPYC 7763 64-Core Processor
collation unit benchmarks - startsWith: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-UTF8_BINARY_LCASE 13064 13080
23 0.0 130635.2 1.0X
-UNICODE 6836 6851
22 0.0 68360.1 1.9X
-UTF8_BINARY 7693 7719
36 0.0 76933.9 1.7X
-UNICODE_CI 488919 495530
9349 0.0 4889190.5 0.0X
+UTF8_BINARY_LCASE 58524 58595
100 0.0 585241.2 1.0X
+UNICODE 50173 50179
10 0.0 501725.2 1.2X
+UTF8_BINARY 7418 7419
1 0.0 74184.3 7.9X
Review Comment:
quite the regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
