sahnib commented on code in PR #46825:
URL: https://github.com/apache/spark/pull/46825#discussion_r1624624406


##########
sql/api/src/main/java/org/apache/spark/sql/streaming/TimeMode.java:
##########
@@ -31,11 +30,6 @@
 @Evolving
 public class TimeMode {
 
-    /**
-     * Neither timers nor ttl is supported in this mode.
-     */
-    public static final TimeMode None() { return NoTime$.MODULE$; }

Review Comment:
   We added this on April 7, 2024 as part of TTL support for Streaming State 
with TransformWithState operator. This operator is a new addition to Spark 
Structured Streaming, and is planned to be released in Spark 4.1. The API is 
currently in heavy development and evolving. I think its safe to make this 
change at this point, given its still unreleased in a Spark Major version. 
   
   cc: @anishshri-db 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to