xupefei commented on code in PR #46849:
URL: https://github.com/apache/spark/pull/46849#discussion_r1630979481
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -48,6 +48,7 @@ message Expression {
CommonInlineUserDefinedFunction common_inline_user_defined_function = 15;
CallFunction call_function = 16;
NamedArgumentExpression named_argument_expression = 17;
+ TypedAggregateExpression typed_aggregate_expression = 18;
Review Comment:
With this new expression it is very easy to identify this `toColumn` usage
and transform it into a query plan which 1:1 matches a plan produced by the
non-Connect version of Spark.
> It is just an invocation with a wild-card
Could you elaborate? Do you mean something like...
`new UserDefinedFunction(...).apply(col("*")).expr` then create a
TypedColumn from it?
I tried this one but it seems more modification is needed to get rid of the
Star.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
