uros-db commented on code in PR #46845:
URL: https://github.com/apache/spark/pull/46845#discussion_r1631168863
##########
sql/core/src/test/resources/sql-tests/inputs/string-functions.sql:
##########
@@ -276,3 +276,16 @@ select luhn_check(6011111111111117);
select luhn_check(6011111111111118);
select luhn_check(123.456);
+--utf8 string validation
+select is_valid_utf8('');
+select is_valid_utf8('abc');
+select is_valid_utf8(x'80');
+select make_valid_utf8('');
+select make_valid_utf8('abc');
+select make_valid_utf8(x'80');
+select validate_utf8('');
+select validate_utf8('abc');
+select validate_utf8(x'80');
+select try_validate_utf8('');
+select try_validate_utf8('abc');
+select try_validate_utf8(x'80');
Review Comment:
we have unit tests that cover both interepreted and codegen paths in
StringExpressionsSuite
these are just e2e sql tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
