sahnib commented on code in PR #46825:
URL: https://github.com/apache/spark/pull/46825#discussion_r1636689844
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ExpiredTimerInfoImpl.scala:
##########
@@ -27,8 +27,7 @@ import org.apache.spark.sql.streaming.{ExpiredTimerInfo,
TimeMode}
*/
class ExpiredTimerInfoImpl(
isValid: Boolean,
- expiryTimeInMsOpt: Option[Long] = None,
- timeMode: TimeMode = TimeMode.None()) extends ExpiredTimerInfo {
Review Comment:
That's a good question. `TimeMode` is passed in the StatefulProcessor.init
function to the user. We were also passing it to the `ExpiredTimerInfoImpl`
but the interface `ExpiredTimerInfo` does not even expose it to the user, and
we never set this variable with proper timeMode. Hence, I have removed it. I
dont think this was intended to here. cc: @anishshri-db can you confirm?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala:
##########
@@ -632,9 +632,9 @@ class MicroBatchExecution(
// Check whether next batch should be constructed
val lastExecutionRequiresAnotherBatch = noDataBatchesEnabled &&
// need to check the execution plan of the previous batch
- execCtx.previousContext.map { plan =>
+ execCtx.previousContext.exists { plan =>
Review Comment:
will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
