dongjoon-hyun commented on code in PR #47001:
URL: https://github.com/apache/spark/pull/47001#discussion_r1643640764
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -1032,9 +1032,19 @@ object Hex {
array
}
+ private def maxArraySize(length: Long): Int = {
Review Comment:
Since this is not reused at all, shall we inline the logic instead of making
a new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
