panbingkun commented on code in PR #47050:
URL: https://github.com/apache/spark/pull/47050#discussion_r1648457747
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -144,7 +143,7 @@ trait Logging {
implicit class LogStringContext(val sc: StringContext) {
def log(args: MDC*): MessageWithContext = {
val processedParts = sc.parts.iterator
- val sb = new StringBuilder(processedParts.next())
+ val sb = new
StringBuilder(StringContext.processEscapes(processedParts.next()))
Review Comment:
@gengliangwang
I have submitted the verified UT as a separate PR here.
https://github.com/apache/spark/pull/47051
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -144,7 +143,7 @@ trait Logging {
implicit class LogStringContext(val sc: StringContext) {
def log(args: MDC*): MessageWithContext = {
val processedParts = sc.parts.iterator
- val sb = new StringBuilder(processedParts.next())
+ val sb = new
StringBuilder(StringContext.processEscapes(processedParts.next()))
Review Comment:
Currently, it looks very perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
