uros-db commented on PR #47011: URL: https://github.com/apache/spark/pull/47011#issuecomment-2186608118
@mihailom-db @yaooqinn this is an interesting topic (which has nothing to do with `CollationBenchmark`) - we could compute either relative speed or relative time, and the way `BenchmarkBase` works now is computing relative speed one pro of using relative time (essentially the inverse of relative speed in this context) would be better precision - no loss of decimals however, all other benchmarks in spark rely on BenchmarkBase and compute relative speed, so I would suggest adding a paramter to `BenchmarkBase` which would allow computing either `RELATIVE_SPEED` (default value) or `RELATIVE_TIME` (inverse that we want for our benchmark) here's what I propose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
