anishshri-db commented on code in PR #47107: URL: https://github.com/apache/spark/pull/47107#discussion_r1664949049
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala: ########## @@ -392,12 +463,126 @@ private[sql] class RocksDBStateStoreProvider case e: Throwable => throw QueryExecutionErrors.cannotLoadStore(e) } } + + private object ColumnFamilyUtils { + private val multColFamiliesDisabledStr = "multiple column families disabled in " + + "RocksDBStateStoreProvider" + + def getVcfIdBytes(id: Short): Array[Byte] = { + val encodedBytes = new Array[Byte](VIRTUAL_COL_FAMILY_PREFIX_BYTES) + Platform.putShort(encodedBytes, Platform.BYTE_ARRAY_OFFSET, id) Review Comment: Can we mention that explicitly in the function comment ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org