mathiasschw-db commented on PR #27: URL: https://github.com/apache/spark-connect-go/pull/27#issuecomment-2208292095
So basically, I am trying to separate some very tightly coupled components
here. You know more about how folks expect to use this so we can keep it in on
package if that is preferable.
I am trying to make the codebase (to some degree) reflect the dependency
diagram from README.md but increasingly decoupling the very highly coupled
components of the package. The current dependencies look like this:
```
+-------------------+
| |
| sparkSessionImpl |
| |
+-------------------+
|
|
+
+-------------------+
| |
| dataFrameImpl |
| |
+-------------------+
|
|
+
+---------------------------+ +----------------+
| | | |
| SparkConnectServiceClient |--------------+| Spark Driver |
| | | |
+---------------------------+ +----------------+
```
That doesn't quite match what the README.md file says (session and dataframe
are reversed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
