cloud-fan commented on code in PR #47026: URL: https://github.com/apache/spark/pull/47026#discussion_r1665388660
########## sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreterSuite.scala: ########## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.scripting + +import org.apache.spark.sql.{AnalysisException, Dataset, QueryTest, Row} +import org.apache.spark.sql.catalyst.QueryPlanningTracker +import org.apache.spark.sql.test.SharedSparkSession + +/** + * SQL Scripting interpreter tests. + * Output from the parser is provided to the interpreter. + * Output from the interpreter (iterator over executable statements) is then checked - statements + * are executed and output DataFrames are compared with expected outputs. + */ +class SqlScriptingInterpreterSuite extends QueryTest with SharedSparkSession { + // Helpers + private def verifySqlScriptResult(sqlText: String, expected: Seq[Seq[Row]]): Unit = { + val interpreter = SqlScriptingInterpreter() + val compoundBody = spark.sessionState.sqlParser.parseScript(sqlText) + val executionPlan = interpreter.buildExecutionPlan(compoundBody) + val result = executionPlan.flatMap { + case statement: SingleStatementExec => Review Comment: I'm thinking about the proper abstraction we should use. What we get at the beginning is the AST `CompoundPlanStatement`, what we need at the end is an iterator of `SingleStatementExec`. In the middle layer we use `CompoundStatementExec`. I don't have a good sense now as loop/if-else is a very important part of the abstraction. Can we implement if-else first so that we can have a better sense of the abstraction? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
