urosstan-db commented on code in PR #47181:
URL: https://github.com/apache/spark/pull/47181#discussion_r1665611394
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala:
##########
@@ -22,11 +22,22 @@ import java.util.Locale
import org.apache.spark.sql.connector.catalog.Identifier
import org.apache.spark.sql.errors.{QueryCompilationErrors,
QueryExecutionErrors}
+import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
private case class DerbyDialect() extends JdbcDialect with NoLegacyJDBCError {
+ /**
+ * Returns jdbc version that this dialect uses.
+ */
+ override def jdbcVersion(): Int =
SQLConf.get.getConf(SQLConf.DERBY_JDBC_VERSION)
Review Comment:
Yeah, I agree, one config for all connectors for common code would be worse
solution.
For example, customer can upgrade MySQL independently from Postgres, even
common parts of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
