grundprinzip commented on code in PR #47215:
URL: https://github.com/apache/spark/pull/47215#discussion_r1665775589
##########
python/pyspark/sql/connect/session.py:
##########
@@ -827,8 +827,16 @@ def stop(self) -> None:
# other remote clients being used from other users.
with SparkSession._lock:
if not self.is_stopped and self.release_session_on_close:
- self.client.release_session()
- self.client.close()
+ try:
Review Comment:
Please add some documentation on why we're doing this - e.g. to recover
easily from network issues and not requiring the final RPC call to be
successful because stop() is the last call of the session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
