mathiasschw-db commented on code in PR #32:
URL: https://github.com/apache/spark-connect-go/pull/32#discussion_r1666834278
##########
cmd/spark-connect-example-spark-session/main.go:
##########
@@ -21,6 +21,8 @@ import (
"flag"
"log"
+ "github.com/apache/spark-connect-go/v35/spark/sql/utils"
Review Comment:
There should not be spaces between these imports
##########
spark/sql/utils/check.go:
##########
@@ -0,0 +1,25 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package utils
+
+import "fmt"
+
+func WarnOnError(f func() error) {
+ if err := f(); err != nil {
+ fmt.Println("Received error:", err)
Review Comment:
You should not use fmt.Println from within library code. At the very
minimum, use a logger but do consider a slightly more general version where you
can pass in an error handler (which can then in turn be something that logs
##########
spark/client/channel/channel_test.go:
##########
@@ -58,6 +58,7 @@ func TestBasicChannelParsing(t *testing.T) {
assert.ErrorIs(t, err, sparkerrors.InvalidInputError)
cb, err = channel.NewBuilder(goodChannelURL)
+ assert.Nilf(t, err, "Should not have an error for a proper URL")
Review Comment:
`assert.NoError` is the right one to use here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
