thomhart31 commented on code in PR #47235:
URL: https://github.com/apache/spark/pull/47235#discussion_r1667033740


##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -5385,6 +5385,24 @@ def countDistinct(col: "ColumnOrName", *cols: 
"ColumnOrName") -> Column:
 
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
+    
+    Examples

Review Comment:
   Agreed. This PR was created to provide consistency with other aliases. For 
instance, the [col 
docstring](https://github.com/apache/spark/blob/f1eca903f5c25aa08be80e9af2df3477e2a5a6ef/python/pyspark/sql/functions/builtin.py#L252)
 demonstrates that `col` and `column` provide the same functionality.



##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -5385,6 +5385,24 @@ def countDistinct(col: "ColumnOrName", *cols: 
"ColumnOrName") -> Column:
 
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
+    
+    Examples

Review Comment:
   Agreed. This PR was created to provide consistency with other aliases. For 
instance, the [col 
docstring](https://github.com/apache/spark/blob/f1eca903f5c25aa08be80e9af2df3477e2a5a6ef/python/pyspark/sql/functions/builtin.py#L252)
 demonstrates that `col` and `column` provide the same functionality.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to