gengliangwang commented on PR #47145: URL: https://github.com/apache/spark/pull/47145#issuecomment-2211496250
@itholic Thanks for working on this. LGTM overall. I notice that there are some difference from the scheme of the scala structured streaming:https://github.com/apache/spark/blob/master/common/utils/src/main/resources/org/apache/spark/SparkLayout.json#L2 * ts => timestamp * msg => message * logger => name Since the JSON Template Layout in Log4j 2.x (https://logging.apache.org/log4j/2.x/manual/json-template-layout.html) does not support multi-line output and Spark generates a significant number of INFO level logs, I opted to use the short names ts and msg for readability. Should we consider making the Python side consistent with this naming convention? Alternatively, if you think it’s more appropriate, we could modify the Scala side instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
