Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/6514#discussion_r31393311
--- Diff: docs/ml-guide.md ---
@@ -207,7 +207,7 @@ val model1 = lr.fit(training.toDF)
// we can view the parameters it used during fit().
// This prints the parameter (name: value) pairs, where names are unique
IDs for this
// LogisticRegression instance.
-println("Model 1 was fit using parameters: " + model1.fittingParamMap)
+println("Model 1 was fit using parameters: " + model1.extractParamMap)
--- End diff --
I should have noticed before: The right way to access the parameters is
really: ```model1.parent.extractParamMap``` since that gets the Params for the
parent Estimator, which could potentially differ from the Model Params. Could
you please update these 4 examples? Other than this, the changes look fine.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
