Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6537#discussion_r31393883
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -127,20 +127,20 @@ trait HiveTypeCoercion {
case e if !e.childrenResolved => e
/* Double Conversions */
- case b: BinaryExpression if b.left == stringNaN &&
b.right.dataType == DoubleType =>
- b.makeCopy(Array(b.right, Literal(Double.NaN)))
- case b: BinaryExpression if b.left.dataType == DoubleType &&
b.right == stringNaN =>
- b.makeCopy(Array(Literal(Double.NaN), b.left))
- case b: BinaryExpression if b.left == stringNaN && b.right ==
stringNaN =>
- b.makeCopy(Array(Literal(Double.NaN), b.left))
+ case b @ BinaryExpression(StringNaN, r @ DoubleType()) =>
+ b.makeCopy(Array(r, Literal(Double.NaN)))
--- End diff --
let's do the minimum thing needed and not switch the order here. No need to
confuse the future user why orders are switched.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
