dbatomic commented on code in PR #47146:
URL: https://github.com/apache/spark/pull/47146#discussion_r1670233826
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -121,24 +121,40 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
visit(s).asInstanceOf[CompoundBody]
}.getOrElse {
val logicalPlan = visitSingleStatement(ctx.singleStatement())
- CompoundBody(Seq(SingleStatement(parsedPlan = logicalPlan)))
+ CompoundBody(Seq(SingleStatement(parsedPlan = logicalPlan)),
+ java.util.UUID.randomUUID.toString)
}
}
override def visitSingleCompoundStatement(ctx:
SingleCompoundStatementContext): CompoundBody = {
visit(ctx.beginEndCompoundBlock()).asInstanceOf[CompoundBody]
}
- private def visitCompoundBodyImpl(ctx: CompoundBodyContext): CompoundBody = {
+ private def visitCompoundBodyImpl(ctx: CompoundBodyContext, label: String =
""): CompoundBody = {
Review Comment:
What is the reason for having default for label as empty string?
My understanding is that we are always going to provide a value to label
(UUID if not provided).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
