LuciferYang commented on code in PR #47197:
URL: https://github.com/apache/spark/pull/47197#discussion_r1670291970
##########
core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala:
##########
@@ -328,19 +354,16 @@ private[spark] object TaskMetrics extends Logging {
*/
def fromAccumulators(accums: Seq[AccumulatorV2[_, _]]): TaskMetrics = {
val tm = new TaskMetrics
- val externalAccums = new java.util.ArrayList[AccumulatorV2[Any, Any]]()
for (acc <- accums) {
val name = acc.name
- val tmpAcc = acc.asInstanceOf[AccumulatorV2[Any, Any]]
if (name.isDefined && tm.nameToAccums.contains(name.get)) {
val tmAcc = tm.nameToAccums(name.get).asInstanceOf[AccumulatorV2[Any,
Any]]
tmAcc.metadata = acc.metadata
- tmAcc.merge(tmpAcc)
+ tmAcc.merge(acc.asInstanceOf[AccumulatorV2[Any, Any]])
} else {
- externalAccums.add(tmpAcc)
+ tm._externalAccums += acc
Review Comment:
Agree with @Ngone51 `tm` is a local variable, and it is unlikely that there
will be a reference to `tm` from outside before this function returns, so I
also believe that there should be no thread safety issues here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
