HyukjinKwon commented on code in PR #47313:
URL: https://github.com/apache/spark/pull/47313#discussion_r1675444996


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -161,7 +161,11 @@ object FileSourceStrategy extends Strategy with 
PredicateHelper with Logging {
       val filterSet = ExpressionSet(filters)

Review Comment:
   I believe I fixed all places that can use `PythonUDF` as partitioning 
filters. For DSv1, we don't pushdown partitioning filters. `PythonUDF` could be 
pushed down, and the downstream datasource can still handle them if they want.
   
   So I fixed:
   - Hive scan with partitoning
   - DSv2 with partitioning
   - FileSource with partitioning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to