wForget commented on code in PR #47303: URL: https://github.com/apache/spark/pull/47303#discussion_r1675562123
########## connect/common/src/test/resources/query-tests/explain-results/function_base64.explain: ########## @@ -1,2 +1,2 @@ -Project [base64(cast(g#0 as binary)) AS base64(CAST(g AS BINARY))#0] +Project [static_invoke(Base64.encode(cast(g#0 as binary), false)) AS base64(CAST(g AS BINARY))#0] Review Comment: I have overridden `toString` method and the `false` is omitted in `charvarchar.sql.out` but still exists in `function_base64.explain`. Is this as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
