nugget-cloud commented on code in PR #47323: URL: https://github.com/apache/spark/pull/47323#discussion_r1675651170
########## python/pyspark/sql/dataframe.py: ########## @@ -3913,10 +3913,11 @@ def unpivot( ids : str, Column, tuple, list Column(s) to use as identifiers. Can be a single column or column name, or a list or tuple for multiple columns. - values : str, Column, tuple, list, optional - Column(s) to unpivot. Can be a single column or column name, or a list or tuple - for multiple columns. If specified, must not be empty. If not specified, uses all - columns that are not set as `ids`. Review Comment: hmm ok i will change the docs and remove the optional and the last line unless you want to change unpivot function to incorporate the functionality in the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org