Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6404#discussion_r31395732
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -629,12 +633,24 @@ class SQLQuerySuite extends QueryTest {
.queryExecution.analyzed
}
- test("test script transform") {
+ test("test script transform for stdout") {
val data = (1 to 100000).map { i => (i, i, i) }
data.toDF("d1", "d2", "d3").registerTempTable("script_trans")
- assert(100000 ===
- sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM
script_trans")
- .queryExecution.toRdd.count())
+ failAfter(Span(20000, Millis)) {
+ assert(100000 ===
+ sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM
script_trans")
+ .queryExecution.toRdd.count())
+ }
+ }
+
+ test("test script transform for stderr") {
+ val data = (1 to 100000).map { i => (i, i, i) }
+ data.toDF("d1", "d2", "d3").registerTempTable("script_trans")
+ failAfter(Span(20000, Millis)) {
--- End diff --
20s is probably long enough that we won't have a problem, but do we really
need this? I'm worried if a jenkins machine is overloaded we might have false
failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
