yaooqinn commented on code in PR #47320: URL: https://github.com/apache/spark/pull/47320#discussion_r1676672222
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala: ########## @@ -3840,8 +3840,8 @@ object functions { /** * Computes the first argument into a string from a binary using the provided character set (one - * of 'US-ASCII', 'ISO-8859-1', 'UTF-8', 'UTF-16BE', 'UTF-16LE', 'UTF-16'). If either argument - * is null, the result will also be null. + * of 'US-ASCII', 'ISO-8859-1', 'UTF-8', 'UTF-16BE', 'UTF-16LE', 'UTF-16', 'UTF-32', 'GB2312', + * 'GBK', 'GB18030', 'BIG5'). If either argument is null, the result will also be null. Review Comment: Yes, UTF-x is always a good choice for users but not always sufficient for reading some materials pre-coded by other charsets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org