dongjoon-hyun commented on PR #47333:
URL: https://github.com/apache/spark/pull/47333#issuecomment-2226727572
This PR replaces 8 places (7 `def replacement` and 1 `val replacement`).
According to the list, this PR skips only two places in `percentiles.scala`?
```
percentiles.scala (2 usages found)
346 override def replacement: Expression = percentile
365 override def replacement: Expression = percentile
```
Two questions.
- Is there a reason to skip `percentiles.scala`? Is this intentional?
- If we are going to replace `percentiles.scala` together, `Expression` is
the only one to have `def replacement` after this PR?
```
$ git grep 'def replacement:'
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
def replacement: Expression
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
override def replacement: Expression = percentile
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
override def replacement: Expression = percentile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
