uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1677169498
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -106,11 +155,13 @@ case class Mode(
val collationAwareBuffer = child.dataType match {
case c: StringType if
!CollationFactory.fetchCollation(c.collationId).supportsBinaryEquality
=>
- val collationId = c.collationId
- val modeMap = buffer.toSeq.groupMapReduce {
- case (k, _) =>
CollationFactory.getCollationKey(k.asInstanceOf[UTF8String], collationId)
+ buffer.toSeq.groupMapReduce {
+ case (k, _) =>
CollationFactory.getCollationKey(k.asInstanceOf[UTF8String], c.collationId)
}(x => x)((x, y) => (x._1, x._2 + y._2)).values
- modeMap
+ case _: ArrayType | _ : StructType if child.dataType.existsRecursively(s
=>
Review Comment:
instead of manually doing `child.dataType.existsRecursively`, use
`UnsafeRowUtils.isBinaryStable(child.dataType)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
