dongjoon-hyun commented on code in PR #12: URL: https://github.com/apache/spark-kubernetes-operator/pull/12#discussion_r1677230957
########## spark-operator/src/main/java/org/apache/spark/k8s/operator/decorators/DriverResourceDecorator.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.k8s.operator.decorators; + +import static org.apache.spark.k8s.operator.utils.ModelUtils.buildOwnerReferenceTo; + +import io.fabric8.kubernetes.api.model.HasMetadata; +import io.fabric8.kubernetes.api.model.ObjectMeta; +import io.fabric8.kubernetes.api.model.ObjectMetaBuilder; +import io.fabric8.kubernetes.api.model.OwnerReference; +import io.fabric8.kubernetes.api.model.Pod; +import lombok.RequiredArgsConstructor; +import org.apache.commons.collections.CollectionUtils; + +/** + * Decorates Driver resources (except the pod). This makes sure all resources have owner reference + * to the driver pod, so they can be garbage collected upon termination. Secondary resources would + * be garbage-collected if ALL owners are deleted. Therefore, operator makes only driver pod has + * owned by the SparkApplication while all other secondary resources are owned by the driver. In + * this way, after driver pod is deleted at the end of each attempt, all other resources would be + * garbage collected automatically. + */ +@RequiredArgsConstructor +public class DriverResourceDecorator implements ResourceDecorator { + private final Pod driverPod; + + @Override + public <T extends HasMetadata> T decorate(T resource) { + boolean ownerReferenceExists = false; + if (CollectionUtils.isNotEmpty(resource.getMetadata().getOwnerReferences())) { + for (OwnerReference o : resource.getMetadata().getOwnerReferences()) { + if (driverPod.getKind().equals(o.getKind()) + && driverPod.getMetadata().getName().equals(o.getName()) + && driverPod.getMetadata().getUid().equals(o.getUid())) { + ownerReferenceExists = true; + break; + } + } + } + if (!ownerReferenceExists) { Review Comment: Shall we add a DEBUG level log for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
