HeartSaVioR commented on code in PR #47336:
URL: https://github.com/apache/spark/pull/47336#discussion_r1677278405
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -193,11 +208,18 @@ class RocksDBFileManager(
version: Long,
useColumnFamilies: Boolean = false): StateStoreChangelogReader = {
val changelogFile = dfsChangelogFile(version)
- if (useColumnFamilies) {
- new StateStoreChangelogReaderV2(fm, changelogFile, codec)
- } else {
- new StateStoreChangelogReaderV1(fm, changelogFile, codec)
+
+ val changelogVersion = getChangelogVersion(useColumnFamilies)
Review Comment:
We'll need to rely on the version info rather than the outer information,
but I understand this is problematic as v1 does not have the version info and
we have to put some workaround logic to determine whether there is a version
info (v1) or not. OK to revisit this when we are going to add v3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
