HeartSaVioR commented on code in PR #47339:
URL: https://github.com/apache/spark/pull/47339#discussion_r1677283996
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala:
##########
@@ -813,6 +813,7 @@ trait StreamTest extends QueryTest with SharedSparkSession
with TimeLimits with
case (key, None) => sparkSession.conf.unset(key)
}
sparkSession.streams.removeListener(listener)
+ StateStore.stop()
Review Comment:
Shall we leave a code comment for the reason we put this here? We already
have StateStore.stop() in afterEach in various test suites, and future reviewer
would like to understand why we can't simply put StateStore.stop() in
afterEach. (I get that, just wanted to help future reviewers.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
