Ngone51 commented on code in PR #47192:
URL: https://github.com/apache/spark/pull/47192#discussion_r1677329365
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -1453,6 +1453,8 @@ private[spark] object JsonProtocolSuite extends
Assertions {
t.setExecutorRunTime(b)
t.setExecutorCpuTime(b)
t.setPeakExecutionMemory(c)
+ t.setPeakOnHeapExecutionMemory(c)
+ t.setPeakOffHeapExecutionMemory(c)
Review Comment:
Shall we also update the TaskMetrics ser/deser in `JsonProtocol`?
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -202,6 +212,14 @@ public long acquireExecutionMemory(long required,
MemoryConsumer requestingConsu
logger.debug("Task {} acquired {} for {}", taskAttemptId,
Utils.bytesToString(got),
requestingConsumer);
}
+
+ if (mode == MemoryMode.OFF_HEAP) {
+ peakOffHeapMemory = Math.max(peakOffHeapMemory,
+ memoryManager.getOffHeapExecutionMemoryUsageForTask(taskAttemptId));
Review Comment:
This introduces the extra lock synchronization to the underlying memory
pool. I wonder if we could do a math calculation for the latest peak memory
like this: peakMemory - releasedMemory + gotMemory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
