ulysses-you commented on code in PR #47321:
URL: https://github.com/apache/spark/pull/47321#discussion_r1677349218


##########
core/src/main/scala/org/apache/spark/storage/BlockManager.scala:
##########
@@ -2164,7 +2164,10 @@ private[spark] class BlockManager(
     diskBlockManager.stop()
     rpcEnv.stop(storageEndpoint)
     blockInfoManager.clear()
-    memoryStore.clear()
+    // The memoryManager may be null if the driver plugin fails to initialize

Review Comment:
   I'm not sure if we should keep starting spark context if driver plguin fail 
to initialize. Before we have fixed an issue for executor plugin 
[SPARK-40320](https://issues.apache.org/jira/browse/SPARK-40320) , by making 
exexutor fast fail when it fails to initialize. So this pr leave driver fast 
fail and just drops the noisy error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to