LuciferYang commented on code in PR #47350: URL: https://github.com/apache/spark/pull/47350#discussion_r1677508322
########## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCommitterSuite.scala: ########## @@ -116,7 +116,7 @@ class ParquetCommitterSuite extends SparkFunSuite with SQLTestUtils test("SPARK-48804: Fail fast on unloadable or invalid committers") { Seq("invalid", getClass.getName).foreach { committer => val e = intercept[IllegalArgumentException] { - withSQLConf(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key -> committer)() + withSQLConf(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key -> committer)(()) Review Comment: Anyway, the current fix is ok for me, although this approach seems more like "having to define an empty function to fix a compilation warning." Also, ``` withSQLConf(SQLConf.PARQUET_OUTPUT_COMMITTER_CLASS.key -> committer) {} ``` is ok too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org