chaoqin-li1123 commented on code in PR #47363:
URL: https://github.com/apache/spark/pull/47363#discussion_r1678722761
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -189,8 +189,13 @@ class RocksDB(
// reset last snapshot version
if (lastSnapshotVersion > latestSnapshotVersion) {
// discard any newer snapshots
- lastSnapshotVersion = 0L
+ synchronized {
+ latestSnapshot = None
Review Comment:
Need to move this snapshot to oldSnapshots so that it can be cleaned up by
maintenance task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
