hvanhovell commented on code in PR #47378:
URL: https://github.com/apache/spark/pull/47378#discussion_r1680313747
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -116,49 +90,18 @@
<shadedArtifactAttached>false</shadedArtifactAttached>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<artifactSet>
+ <!-- TODO make sure this is complete. -->
Review Comment:
... and yes I still need to check iif the shading rules between SBT and
maven are still consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
