chaoqin-li1123 commented on code in PR #47393:
URL: https://github.com/apache/spark/pull/47393#discussion_r1681833016
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -185,6 +185,8 @@ class RocksDB(
val latestSnapshotVersion =
fileManager.getLatestSnapshotVersion(version)
val metadata =
fileManager.loadCheckpointFromDfs(latestSnapshotVersion, workingDir)
loadedVersion = latestSnapshotVersion
+ // Initialize maxVersion upon successful load from DFS
+ fileManager.initializeMaxVersion()
Review Comment:
Always do a listing to discover the max version in load() is a waste of
resource, you can simply call
_fileManager.setMaxVersion(version)_
Because usually the latest version is loaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
