panbingkun commented on code in PR #47401: URL: https://github.com/apache/spark/pull/47401#discussion_r1682468013
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollationExpressionSuite.scala: ########## @@ -28,14 +28,14 @@ class CollationExpressionSuite extends SparkFunSuite with ExpressionEvalHelper { assert(collationId == 0) val collateExpr = Collate(Literal("abc"), "UTF8_BINARY") assert(collateExpr.dataType === StringType(collationId)) - collateExpr.dataType.asInstanceOf[StringType].collationId == 0 Review Comment: fix an `miss` check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org