davidm-db commented on code in PR #47272:
URL: https://github.com/apache/spark/pull/47272#discussion_r1682490057
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -251,26 +258,29 @@ statement
| (MSCK)? REPAIR TABLE identifierReference
(option=(ADD|DROP|SYNC) PARTITIONS)?
#repairTable
| op=(ADD | LIST) identifier .*?
#manageResource
- | SET COLLATION collationName=identifier
#setCollation
- | SET ROLE .*?
#failNativeCommand
+ | CREATE INDEX (IF errorCapturingNot EXISTS)? identifier ON TABLE?
+ identifierReference (USING indexType=identifier)?
+ LEFT_PAREN columns=multipartIdentifierPropertyList RIGHT_PAREN
+ (OPTIONS options=propertyList)?
#createIndex
+ | DROP INDEX (IF EXISTS)? identifier ON TABLE? identifierReference
#dropIndex
+ | unsupportedHiveNativeCommands .*?
#failNativeCommand
+ ;
+
+setResetStatement
+ : SET COLLATION collationName=identifier
#setCollation
+ | SET ROLE .*?
#failSetRole
| SET TIME ZONE interval
#setTimeZone
| SET TIME ZONE timezone
#setTimeZone
| SET TIME ZONE .*?
#setTimeZone
Review Comment:
This is what we agreed on with Serge offline. We agreed on this approach for
now, and once we figure out how to resolve the problem with `SET .*?` rule
(`#setConfiguration`) then we will start releasing these constraints and
bringing back all of the `SET` statements. Until them, each of them, if needed,
can still be executed from scripts using `EXECUTE IMMEDIATE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
