dongjoon-hyun commented on code in PR #12: URL: https://github.com/apache/spark-kubernetes-operator/pull/12#discussion_r1683065521
########## spark-operator/src/main/java/org/apache/spark/k8s/operator/utils/PodPhase.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.k8s.operator.utils; + +import io.fabric8.kubernetes.api.model.Pod; +import lombok.extern.slf4j.Slf4j; + +/** + * Defines common (driver) pod phases that may need to be handled explicitly by the operator. For + * pod phase definition: {@see + * https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-phase} + */ +@Slf4j +public enum PodPhase { + PENDING("pending"), + RUNNING("running"), + FAILED("failed"), + SUCCEEDED("succeeded"), + UNKNOWN("unknown"); + + private final String description; + + PodPhase(String description) { Review Comment: Why do we allow this argument? It seems to make the `getPhase` logic complex without a clear benefit. Could you add some design goal of this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
