davidm-db commented on code in PR #47404: URL: https://github.com/apache/spark/pull/47404#discussion_r1683089130
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -161,11 +185,11 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper with Logging { val labelText = beginLabelCtx. map(_.multipartIdentifier().getText).getOrElse(java.util.UUID.randomUUID.toString). toLowerCase(Locale.ROOT) - visitCompoundBodyImpl(ctx.compoundBody(), Some(labelText)) + visitCompoundBodyImpl(ctx.compoundBody(), Some(labelText), true) Review Comment: we are usually using named parameters when passing explicit boolean values, so it's clear what `true` means in this context. same goes for the `false` below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org