wayneguow commented on PR #47414: URL: https://github.com/apache/spark/pull/47414#issuecomment-2239746681
> To @wayneguow , please mention the following in the PR description and title. It improves the visibility of your contribution. Since it's non-trivial contribution, I'd recommend you to get a better credit in the community for this activity. This PR is better than a simple version-string-change PR, isn't it? 😄 > > > Yes. After this commit( [h2database/h2database@186647d](https://github.com/h2database/h2database/commit/186647d4a35d05681febf4f53502b306aa6d511a)), the behavior of asin and acos has changed in h2, complying with Standard SQL, and throwing exceptions directly when the argument is invalid(< -1d || > 1d). @dongjoon-hyun I really appreciate your guidance, not merely for helping me do things right, but for empowering me to make greater progress in the future. Let's do better. 😀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
