gengliangwang commented on code in PR #47405:
URL: https://github.com/apache/spark/pull/47405#discussion_r1684811673
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/parsers.scala:
##########
@@ -249,20 +249,24 @@ class ParseException private(
override def getMessage: String = {
val builder = new StringBuilder
builder ++= "\n" ++= message
- start match {
- case Origin(Some(l), Some(p), _, _, _, _, _, _, _) =>
- builder ++= s" (line $l, pos $p)\n"
- command.foreach { cmd =>
- val (above, below) = cmd.split("\n").splitAt(l)
- builder ++= "\n== SQL ==\n"
- above.foreach(builder ++= _ += '\n')
- builder ++= (0 until p).map(_ => "-").mkString("") ++= "^^^\n"
- below.foreach(builder ++= _ += '\n')
- }
- case _ =>
- command.foreach { cmd =>
- builder ++= "\n== SQL ==\n" ++= cmd
- }
+ if (queryContext.nonEmpty) {
+ builder ++= queryContext.head.summary()
Review Comment:
Shall we append all the summaries from `queryContext` instead of just the
first query context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
