panbingkun commented on code in PR #47364: URL: https://github.com/apache/spark/pull/47364#discussion_r1686161417
########## docs/sql-ref-ansi-compliance.md: ########## @@ -442,6 +442,7 @@ Below is a list of all the keywords in Spark SQL. |CODEGEN|non-reserved|non-reserved|non-reserved| |COLLATE|reserved|non-reserved|reserved| |COLLATION|reserved|non-reserved|reserved| +|COLLATIONS|reserved|non-reserved|reserved| Review Comment: Okay, The reason for using `COLLATIONS` is that I want to follow some of Spark's `unwritten rules`, eg: https://github.com/apache/spark/blob/42d14799c9833e011765677122e2fbb1667467da/sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L223 https://github.com/apache/spark/blob/42d14799c9833e011765677122e2fbb1667467da/sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L227 https://github.com/apache/spark/blob/42d14799c9833e011765677122e2fbb1667467da/sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L229 Of course, if we decide to use `COLLATION`, I am fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
