LuciferYang commented on code in PR #47418: URL: https://github.com/apache/spark/pull/47418#discussion_r1686486058
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/V1Writes.scala: ########## @@ -43,7 +43,7 @@ trait V1WriteCommand extends DataWritingCommand { /** * Specify the partition spec of the V1 write command. */ - def staticPartitions: TablePartitionSpec + def statementStaticPartitions: TablePartitionSpec Review Comment: Why do we need to rename this function? Has its definition changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org