chaoqin-li1123 commented on code in PR #47393:
URL: https://github.com/apache/spark/pull/47393#discussion_r1687060460
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -426,7 +441,29 @@ class RocksDBFileManager(
* - SST files that were used in a version, but that version got overwritten
with a different
* set of SST files.
*/
- def deleteOldVersions(numVersionsToRetain: Int): Unit = {
+ def deleteOldVersions(numVersionsToRetain: Int, minVersionsToDelete: Long =
0): Unit = {
+ // If minVersionsToDelete <= 0, we call list every time maintenance is
invoked
+ // This is the original behaviour without list api call optimization
+ if (minVersionsToDelete > 0) {
Review Comment:
Can we move this part to a helper function? deleteOldVersions is already a
too long function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
